From 39adcdb9e4ed6a310244695115f2bef31406ae19 Mon Sep 17 00:00:00 2001
From: "Jesse C. Fisher" <jessecfisher@gmail.com>
Date: Thu, 9 Apr 2015 17:17:51 -0700
Subject: [PATCH] Game start spec

---
 app/models/game.rb       |  6 +++---
 spec/models/game_spec.rb | 22 +++++++++++++---------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/app/models/game.rb b/app/models/game.rb
index 1897fede..f80397cc 100644
--- a/app/models/game.rb
+++ b/app/models/game.rb
@@ -13,15 +13,15 @@ class Game < ActiveRecord::Base
   end
 
   def validate_startable
-    @player_count = players.count
-    errors[:notice] = 'Must be at least 2 players.'  if @player_count < 2
+    @player_count = players.size
+    errors[:players] = 'Must be at least 2 players.'  if @player_count < 2
     errors[:players] = 'Must be less than 5 players.'  if @player_count > 4
   end
 
   def startable?
     @player_count = players.size
     bool = @player_count.between?(2, 4)
-    bool = status != 'Game Started'
+    #bool = status != 'Game Started'
   end
 
   def add_player_from_user(user)
diff --git a/spec/models/game_spec.rb b/spec/models/game_spec.rb
index 34aff4d6..d9b7fc96 100644
--- a/spec/models/game_spec.rb
+++ b/spec/models/game_spec.rb
@@ -14,26 +14,30 @@ RSpec.describe Game, type: :model do
   describe 'validations' do
     describe 'player_count' do
       context 'when there are between 2 and 4 players' do
-        it 'is valid' do
+        it 'is startable' do
           @game.players.new
           @game.players.new
-          expect(@game).to be_valid
+          expect(@game.players.size).to eq(2)
+          expect(@game.startable?).to eq(true)
         end
       end
 
       context 'when there are less than 2 players' do
-        it 'fails validation with too few players' do
-          expect(@game).to_not be_valid
+        it 'is not startable with too few players' do
+          @game.validate_startable
+          expect(@game.players.size).to eq(0)
+          expect(@game.startable?).to eq(false)
           expect(@game.errors[:players])
             .to include 'Must be at least 2 players.'
         end
       end
       context 'when there are more than 4 players' do
         it 'fails validation with too many players' do
-          5.times do
+          6.times do
             @game.players.new
           end
-          expect(@game).to_not be_valid
+          @game.validate_startable
+          expect(@game.startable?).to eq(false)
           expect(@game.errors[:players])
             .to include 'Must be less than 5 players.'
         end
@@ -41,7 +45,7 @@ RSpec.describe Game, type: :model do
     end
   end
 
-  it 'Can not be started if game is invalid' do
-    expect(@game.start).to raise_error
-  end
+  #it 'Can not be started if game is invalid' do
+    #expect(@game.start).to raise_error
+  #end
 end